Trac

trac@lists.einsteintoolkit.org

8708 discussions

#2571: runtime failure due to useing character*8 in DECLARE_CCTK_ARGUMENTS_CHECKED macro
by Roland Haas 17 Nov '21

17 Nov '21

#2571: runtime failure due to useing character*8 in DECLARE_CCTK_ARGUMENTS_CHECKED macro Reporter: Roland Haas Status: new Milestone: Version: development version Type: bug Priority: major Component: Cactus Comment (by Roland Haas): Please review. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2571/runtime-failure-d…

1 0

#2571: runtime failure due to useing character*8 in DECLARE_CCTK_ARGUMENTS_CHECKED macro
by Roland Haas 17 Nov '21

17 Nov '21

#2571: runtime failure due to useing character*8 in DECLARE_CCTK_ARGUMENTS_CHECKED macro Reporter: Roland Haas Status: new Milestone: Version: development version Type: bug Priority: major Component: Cactus Comment (by Roland Haas): Pull request is here: [https://bitbucket.org/cactuscode/cactus/pull-requests/131/cactus-define-cus… -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2571/runtime-failure-d…

1 0

#2551: include RePriMand in the ET
by Roland Haas 17 Nov '21

17 Nov '21

#2551: include RePriMand in the ET Reporter: Roland Haas Status: open Milestone: ET_2021_11 Version: development version Type: enhancement Priority: major Component: Comment (by Roland Haas): The deep freeze for the release is going to be very soon. The documentation should go into `public` as soon as possible. Please also take a look at the review comments. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2551/include-reprimand…

1 0

#2497: IllinoisGRMHD is incompatible with setting TmunuBase::stress_energy_at_RHS = "no"
by Gabriele Bozzola 17 Nov '21

17 Nov '21

1 0

#2497: IllinoisGRMHD is incompatible with setting TmunuBase::stress_energy_at_RHS = "no"
by Roland Haas 17 Nov '21

17 Nov '21

#2497: IllinoisGRMHD is incompatible with setting TmunuBase::stress_energy_at_RHS = "no" Reporter: Gabriele Bozzola Status: open Milestone: Version: development version Type: bug Priority: major Component: EinsteinToolkit thorn Comment (by Roland Haas): Part of the issue may be that ILGRMHD’s Tmunu code actually does non-Tmunu things namely con2prim as far as I remember. So not scheduling the Tmunu routines is not possible. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2497/illinoisgrmhd-is-…

1 0

#2497: IllinoisGRMHD is incompatible with setting TmunuBase::stress_energy_at_RHS = "no"
by Gabriele Bozzola 17 Nov '21

17 Nov '21

#2497: IllinoisGRMHD is incompatible with setting TmunuBase::stress_energy_at_RHS = "no" Reporter: Gabriele Bozzola Status: open Milestone: Version: development version Type: bug Priority: major Component: EinsteinToolkit thorn Comment (by Gabriele Bozzola): Upon further inspection, the PR does not solve the problem. The group `SetTmunu` is not added to the scheduler when `TmunuBase::stress_energy_at_RHS = "no"` I don’t know how to fix this in a clean and easy way. The scheduler looks like this ``` GROUP HydroBase_Con2Prim: Convert from conservative to primitive variables GROUP SetTmunu: Group for calculating the stress-energy tensor TmunuBase::TmunuBase_ZeroTmunu: Initialise the stress-energy tensor to zero GROUP AddToTmunu: Add to the stress-energy tensor here IllinoisGRMHD::IllinoisGRMHD_conserv_to_prims: Compute primitive variables from conservatives. This is non-trivial, requiring a Newton-Raphson root-finder. IllinoisGRMHD::IllinoisGRMHD_outer_boundaries_on_P_rho_b_vx_vy_vz: Apply outflow-only, flat BCs on {P,rho_b,vx,vy,vz}. Outflow only == velocities pointed inward from outer boundary are set to zero. ``` `IllinoisGRMHD` computes Tmunu when it is doing primitive-recovery \(in `IllinoisGRMHD_convser_to_prims`\), so, it has to be scheduled after `TmunuBase_ZeroTmunu`. However, the group `SetTmunu` does not exist at all when \``TmunuBase::stress_energy_at_RHS = "no"` -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2497/illinoisgrmhd-is-…

1 0

#2576: `after` statements in scheduler in `IllinoisGRMHD`
by Roland Haas 17 Nov '21

17 Nov '21

#2576: `after` statements in scheduler in `IllinoisGRMHD` Reporter: Gabriele Bozzola Status: new Milestone: Version: development version Type: bug Priority: major Component: EinsteinToolkit thorn Comment (by Roland Haas): Non existent functions in an `AFTER` or `BEFORE` \(and also `IN`\) clause in `schedule.ccl` are allowed in Cactus.They can for example be defined by thorns that are not included in the thornlist \(and may be private\). Eg `BSSN_RegisterVars` may be of that type. However your list also contains some that would seem to be in IllinoisGRMHD itself so their exclusion looks like a bug to me. Assigning to the ILGRMHD author \(and maintainer\) @{557058:8bc23f2a-45c0-477d-8ac4-a5a16c734278} -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2576/after-statements-…

1 0

#2576: `after` statements in scheduler in `IllinoisGRMHD`
by Roland Haas 17 Nov '21

17 Nov '21

#2576: `after` statements in scheduler in `IllinoisGRMHD` Reporter: Gabriele Bozzola Status: new Milestone: Version: development version Type: bug Priority: major Component: EinsteinToolkit thorn Changes (by Roland Haas): assignee: Zach Etienne (was ) responsible: [] (was ) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2576/after-statements-…

1 0

#2497: IllinoisGRMHD is incompatible with setting TmunuBase::stress_energy_at_RHS = "no"
by Gabriele Bozzola 16 Nov '21

16 Nov '21

1 0

#2576: `after` statements in scheduler in `IllinoisGRMHD`
by Gabriele Bozzola 16 Nov '21

16 Nov '21

#2576: `after` statements in scheduler in `IllinoisGRMHD` Reporter: Gabriele Bozzola Status: new Milestone: Version: development version Type: bug Priority: major Component: EinsteinToolkit thorn In fixing #2497, I found that several `after` statements in the `schedule.ccl` of `IllinoisGRMHD` \(but probably also `GiRaFFE`\) are ill-defined \(or I don't know how the scheduler works\). In particular, according to `grep`, the following groups do not exist in the `Einstein Toolkit`: * `BSSN_RegisterVars` * `lapse_RegisterVars` * `Lapse_InitSymBound` * `empostid` * `lapsepostid` * `p2c` * `bssn_rhs` * `shift_rhs` * `compute_B_postrestrict` * `mhd_conserv2prims_postrestrict` * `outer_boundaries_on_A_mu` \(probably this one should be `IllinoisGRMHD_outer_boundaries_on_A_mu`\) * `compute_B_and_Bstagger_from_A` \(probably this one should be `IllinoisGRMHD_compute_B_and_Bstagger_from_A`\) In addition to this: * `IllinoisGRMHD_compute_B_and_Bstagger_from_A` is scheduled in `HydroBase_Boundaries`, but then `IllinoisGRMHD_conserv_to_prims` to be after `compute_B_and_Bstagger_from_A`, but it is scheduled in another group \(originally `AddToTmunu`, but with my fix it is `SetTmunu`\), so I am not sure what’s the use of that `after` * `IllinoisGRMHD` does not define `READ/WRITE` statements ‌ -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2576/after-statements-…

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Trac