On Tue, May 27, 2014 at 11:23:48AM -0400, Erik Schnetter wrote:
As per our previous discussion, the standard ET thorn list will (and this
Hi,
Yes - everything should be fine when using the ET thornlist. I am actually for the change you proposed (this is assuming simfactory only enables thorns that are 'commented out' in thornlists).
I just wanted to note that simfactory has to work with other thornlists too. And these thornlists might contain, say, thorn CUDA, commented out. But that thorn (its source code) might not be present. In this case simfactory would enable CUDA, which would break the build - possibly surprising the user ("But CUDA is commented out - why does it try to build it?"). We cannot assume every user of simfactory knows about the 'enabled-thorns' feature. It would be nice to be able to point the user to the interaction between simfactory and the thornlist in that case, telling them to either get the CUDA thorn, or remove it entirely from the thornlist as commenting out does not necessarily mean 'do not compile' with simfactory.
Frank