Hello all,
Some remarks:
- What machine is 105aff02?
Machines with just hexadecimal names are my laptops.
- Why are the Dissipation testsuites failing on
BW/Comet/Edison/Cori/Golub/Hydra? (ADMConstraints? ... see below) On BW they don't seem to produce output at all, but on the others the same number of sufficiently different files suggest a common cause.
- sphere_pugh_ppm is one of the 'fails a bit sometimes' thorns, and
has been for a while. It's not a release-blocker, but a candidate we should look at. This might very well be a not optimal testsuite setup.
- RotatingSymmetry90/180 testsuites also seem to fail on
Golum/Edison/Cori. I seem to remember that, like Dissipation, they use ML_ADMConstraints results in the testsuite. Could you please check if the workaround is already applied in the source that is tested here, i.e., if the workaround does not work here?
- We should probably disable OpenCL for BW if not even the WaveToy
works there: keep it commented out in the optionlist, but don't enable it by default, because it might fool people in thinking it should work.
Would you mind adding those comments on the wiki page that I had mentioned in the minutes, please? That way they are in one place and not scattered throughout multiple emails.
https://docs.einsteintoolkit.org/et-docs/Release_coordination
which already has sections for the different machines and has my assessment on the BW issue and at least one guess for the failure of Dissipation (though the SEGFAULT on BW persists).
Overall, this looks really quite good - in fact, better than at some other times for a release.
Yes.
Keep adding/updating testsuites, I'll prepare release notes and get everything ready for a release. For now, I will not create release branches before that status of ML_ADMConstraints is sorted out (patch is in the works, but not in master and not widely tested yet).
Ok, thank you.
Yours, Roland