Hi Roland,
I'm always nervous when a big Carpet update comes down the pipeline. Could you please confirm the full ETK testsuite passes with the new version of Carpet before pushing to master? There are a lot of Carpet features that aren't tested by qc0-mclachlan.par, but are tested by the testsuite.
-Zach
* * * Zachariah Etienne Assistant Professor of Mathematics West Virginia University *https://math.wvu.edu/~zetienne/ https://math.wvu.edu/~zetienne/* https://blackholesathome.net
On Wed, Oct 3, 2018 at 10:07 AM Einstein Toolkit < trac-noreply@einsteintoolkit.org> wrote:
#2203: accumulated Carpet updates --------------------------+--------------------------------- Reporter: Roland Haas | Owner: Roland Haas Type: defect | Status: assigned Priority: minor | Milestone: Component: Carpet | Version: development version Resolution: | Keywords: --------------------------+---------------------------------
Comment (by Roland Haas):
These are (almost there is a single commit of mine in the Cactus pull request) Erik's changes, and I have already reviewed them and tested them on my workstation.
I will leave this ticket open until Tuesday Oct 9 2018 and then apply all changes in the pull request unless there are objections.
-- Ticket URL: https://trac.einsteintoolkit.org/ticket/2203#comment:1 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit _______________________________________________ Trac mailing list Trac@einsteintoolkit.org http://lists.einsteintoolkit.org/mailman/listinfo/trac