Hi Roland,
your patch seems correct to me if w_lorentz_2 actually represents the square of the lorentz factor. If it does, then we would have to modify in other parts of the file where it is being consistently defined as w^2=1-v^2. However, I suspect that this definition of w is more in the lines of equation 2.17 of Shibata et al's PRD68, 084020 (2003). I am checking the equations again to see if this is true or not and will get back to you later. Hopefully we can clear up any inconsistency there.
Cheers... Bruno.
Roland Haas wrote:
Hello all,
the attached patch should to fix what seems to be a wrong definition of the Lorentz factor in the source term computation of TOVSolver. This is only needed for non-zero speeds.
Both patched and unpatched versions pass (TwoPunctures') bhns-eval testsuite (since the testsuite does not test non-zero speeds).
Ok to apply?
Yours, Roland
Users mailing list Users@einsteintoolkit.org http://lists.einsteintoolkit.org/mailman/listinfo/users