On May 25, 2010, at 9:37 , Bruno C. Mundim wrote:
Hi Roland:
Roland Haas wrote:
Bruno Coutinho Mundim wrote:
Hi Roland,
your patch seems correct to me if w_lorentz_2 actually represents the square of the lorentz factor. If it does, then we would have to modify in other parts of the file where it is being consistently defined as w^2=1-v^2.
Thanks. I had not noticed those.
After looking at the equations carefully yesterday, I would strongly suggest that you apply your patch to all definitions of w_lorentz_2 in external.inc. The equations there do follow the Valencia formulation as, for example, it appears in eqs. 26 and 27 of Font et al's paper (gr-qc/9811015).
You could add comments to the code, either to the definitions of these variables or to the overall README. Pointing to literature in the code will help future readers a lot.
-erik