On Mon, Nov 23, 2015 at 03:02:31PM -0600, Frank Loeffler wrote:
On Mon, Nov 23, 2015 at 03:46:44PM -0500, Erik Schnetter wrote:
These changes are independent of the clang-format version. You are most likely missing the file Cactus/.clang-format that defines how to format the code. By default, clang-format assumes C++11 compilers for C++ code, but some machines cannot handle this yet, so we format for the C++03 standard. (This is the option "Standard: Cpp03" in .clang-format.)
I do have a .clang-format in my Cactus root directory (and the carpet clone is inside that).
I did have such a file, but it seemed to be an old version somehow, not linked to the version in the Cactus flesh.
What I now get is this:
$ git clone https://bitbucket.org/eschnett/carpet.git Cloning into 'carpet'... remote: Counting objects: 42560, done. remote: Compressing objects: 100% (12134/12134), done. remote: Total 42560 (delta 31633), reused 40689 (delta 30202) Receiving objects: 100% (42560/42560), 59.30 MiB | 35.51 MiB/s, done. Resolving deltas: 100% (31633/31633), done. Checking connectivity... done. +knarf@topf:~/ET_dev/repos$ cd carpet/Carpet/src/ +knarf@topf:~/ET_dev/repos/carpet/Carpet/src$ clang-format-3.5 -i *.hh *.cc YAML:18:29: error: invalid boolean BreakBeforeBinaryOperators: None ^~~~ Error reading /home/knarf/ET_dev/.clang-format: Invalid argument Can't find usable .clang-format, using LLVM style ... <many lines>
... and since it falls back to LLVM style the same changes.
To get it to work, I would have to take these out:
BreakBeforeBinaryOperators BinPackArguments ObjCBlockIndentWidth AlwaysBreakAfterDefinitionReturnType SpaceAfterCStyleCast AllowShortCaseLabelsOnASingleLine AlignAfterOpenBracket ... I stopped here. The current .clang-format is clearly not version for clang-format-3.5 and below.
Frank