Hi Erik,

I set OPENMPI_INC_DIRS=${OPENMPI_DIR}/include only if the user decided to build the library. This should be the default include directory only for that case. It doesn't make sense to me building the library and setting the include and lib directories to point elsewhere, outside the library tree directory just built. What do you think?

Cheers, Bruno.

Erik Schnetter wrote:

Bruno

This change sets OPENMPI_INC_DIRS unconditionally, overwriting the user's configuration. If you look further down in the file, you will see the line

: ${OPENMPI_INC_DIRS="${OPENMPI_DIR}/include"}

which sets OPENMPI_INC_DIRS iff the user has not already set it. That is, your change should not be necessary.

I will revert this change.

-erik

On Mon, Dec 19, 2011 at 1:05 AM, bcmsma@astro.rit.edu wrote:

...

User: bmundim Date: 2011/12/19 12:05 AM

Modified: /trunk/ configure.sh

Log: Indicate include and lib directories when building this library.

File Changes:

Directory: /trunk/

File [modified]: configure.sh Delta lines: +2 -0 =================================================================== --- trunk/configure.sh 2011-12-19 04:12:48 UTC (rev 4) +++ trunk/configure.sh 2011-12-19 06:05:49 UTC (rev 5) @@ -84,6 +84,8 @@ fi DONE_FILE=${SCRATCH_BUILD}/done/${THORN} OPENMPI_DIR=${INSTALL_DIR}

• OPENMPI_INC_DIRS=${OPENMPI_DIR}/include
• OPENMPI_LIB_DIRS=${OPENMPI_DIR}/lib

( exec >&2 # Redirect stdout to stderr

---

Commits mailing list Commits@cactuscode.org http://cactuscode.org/mailman/listinfo/commits