On 25/11/11 4:58 AM, Einstein Toolkit wrote:
#677: parameter default change in CarpetIOASCII ----------------------------------------+----------------------------------- Reporter: baiotti@… | Owner: eschnett Type: enhancement | Status: new Priority: optional | Milestone: Component: Carpet | Version: Resolution: | Keywords: CaroetIOASCII parameter default ----------------------------------------+-----------------------------------
Comment (by eschnett):
A quick note: If a parameter is deprecated, it should not be used if possible, and consequently its default should not be changed either.
I think that no one uses 3D ASCII output, so those two (of the four) parameters are irrelevant, but in general I don't agree. Unless a parameter has no effect in the code, a default may be better than another, even if the parameter is deprecated.
In the specific case, the proposed default is better. By the way, why were the parameters deprecated (again no one uses those two parameters anyway I believe)?
Luca
Luca
I didn't mean to disagree with you: it may indeed be time to make Carpet's ASCII output more user friendly but omitting ghost zones, i.e. to change the defaults for some of the parameters you mentioned. However, for the deprecated parameter, the plan is to make them go away (or to turn them into no-ops, i.e. to completely ignore them in the code).
-erik
On Sat, Nov 26, 2011 at 8:23 PM, Luca Baiotti baiotti@ile.osaka-u.ac.jp wrote:
On 25/11/11 4:58 AM, Einstein Toolkit wrote:
#677: parameter default change in CarpetIOASCII ----------------------------------------+----------------------------------- Reporter: baiotti@… | Owner: eschnett Type: enhancement | Status: new Priority: optional | Milestone: Component: Carpet | Version: Resolution: | Keywords: CaroetIOASCII parameter default ----------------------------------------+-----------------------------------
Comment (by eschnett):
A quick note: If a parameter is deprecated, it should not be used if possible, and consequently its default should not be changed either.
I think that no one uses 3D ASCII output, so those two (of the four) parameters are irrelevant, but in general I don't agree. Unless a parameter has no effect in the code, a default may be better than another, even if the parameter is deprecated.
In the specific case, the proposed default is better. By the way, why were the parameters deprecated (again no one uses those two parameters anyway I believe)?
Luca _______________________________________________ Users mailing list Users@einsteintoolkit.org http://lists.einsteintoolkit.org/mailman/listinfo/users
users@lists.einsteintoolkit.org