#1743: Reduce number of output files per directory
----------------------+-----------------------------------------------------
Reporter: eschnett | Owner:
Type: defect | Status: new
Priority: unset | Milestone:
Component: Other | Version: development version
Keywords: |
----------------------+-----------------------------------------------------
Reduce the number of output files per directory in CarpetIOHDF5 by
creating a hierarchy of subdirectories.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1743>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1819: CarpetMask: add option to exclude boxes
-------------------------------------+--------------------------------------
Reporter: bmundim | Owner: eschnett
Type: enhancement | Status: new
Priority: unset | Milestone:
Component: Carpet | Version: development version
Keywords: CarpetMask CarpetReduce |
-------------------------------------+--------------------------------------
I would like to be able to exclude boxes in addition to spherical surfaces
when setting the CarpetMask::weight (which is used by CarpetReduce to
exclude regions when performing
reductions). The following pull request implements this functionality:
{{{
https://bitbucket.org/eschnett/carpet/pull-requests/5/bcm-carpetmask/diff
}}}
I have some parameter files I used to test my implementation. I can turn
them into testsuites after the revision of this ticket.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1819>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1987: QuasyLocalMeasures: Speed up building with gfortran
-----------------------------------+----------------------------------------
Reporter: eschnett | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: EinsteinToolkit thorn | Version: development version
Keywords: |
-----------------------------------+----------------------------------------
Speed up gfortran builds by splitting expensive routines into two,
separating compute kernels from boundary condition calls.
See <https://bitbucket.org/einsteintoolkit/einsteinanalysis/pull-
requests/6/quasylocalmeasures-speed-up-building-with/diff>.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1987>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1997: Backport several simfactory commits to ET_2016_11
----------------------+-----------------------------------------------------
Reporter: hinder | Owner:
Type: defect | Status: new
Priority: major | Milestone:
Component: Other | Version: development version
Keywords: backport |
----------------------+-----------------------------------------------------
Several simfactory commits should be backported to ET_2016_11. These are:
{{{
* a02707c - (HEAD, origin/master) fedora: add hdf5_hl to HDF5_LIB for
PITTNullCode/SphericalHarmonicRecon (2016-12-12) <Roland Haas>
* ce1ee9b - fedora: explicitly install python2 since python3 is the
default in FC25 (2016-12-12) <Roland Haas>
* 72518a0 - minerva: update cluster name (2016-12-12) <Roland Haas>
}}}
Some other commits relating to jacobi-uwm may also be candidates for
backport. Roland?
There should then be an ET_2016_11_v1 release tag created, unless someone
feels that we may have more commits to backport soon.
OK?
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1997>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1994: PITTNUllCode/SphericalHarmonicRecon uses HDF5 1.8 functions
------------------------------------+---------------------------------------
Reporter: rhaas | Owner:
Type: defect | Status: new
Priority: minor | Milestone:
Component: EinsteinToolkit thorn | Version: development version
Keywords: SphericalHarmonicRecon |
------------------------------------+---------------------------------------
SphericalHarmonicRecon's Recon.cc file uses H5LTread_dataset_double
(https://support.hdfgroup.org/HDF5/doc/HL/RM_H5LT.html#H5LTread_dataset_doub…)
which is only available in the hdf5 hl level library which is only
provided in hdf5 1.8.7.
Nothing in the ET states that HDF5 1.8 is required.
This can be fixed my making sure that hdf5_hl is included in HDF5_LIBS
which also will make compilation fail if the library in indeed missing.
We should decide whether we want to bump ExternalLibraries/HDF5's version
number and have it itself check for HDF5 1.8 in which case thorns can rely
on this version being present (if they require a new enough HDF5
ExternalLibraries) or provide workarounds in Reconn.cc.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1994>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1993: fix piecewise polytropes in LORENE1
-----------------------------------+----------------------------------------
Reporter: rhaas | Owner:
Type: defect | Status: new
Priority: major | Milestone:
Component: EinsteinToolkit thorn | Version: development version
Keywords: LORENE |
-----------------------------------+----------------------------------------
LORENE1 constains a bug when handling piecewise polytropes that was
reported to the LORENE developers by Sebastiano Bernuzzi et al. However
the fix is only in our LORENE2 ExternalLibrary (after the incompatible
file format change) so this patch aim to import Sebastiano's original fix
into LORENE as patch.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1993>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1973: Hydro_Analysis: fix scheduling to access grid functions in local mode
-----------------------------------+----------------------------------------
Reporter: rhaas | Owner:
Type: defect | Status: new
Priority: major | Milestone:
Component: EinsteinToolkit thorn | Version: development version
Keywords: HydroAnalysis |
-----------------------------------+----------------------------------------
HydroAnalysis tried to execute some routines accesses grid function data
while in global mode. This leads to incorrect behaviour (namely nothing is
done) and also LoopControl asserting about nonsensical imin/imax values.
This seems to have been in HydroAnalysis from the very beginning.
Pull request is here:
https://bitbucket.org/einsteintoolkit/einsteinanalysis/pull-requests/4
/hydro_analysis-fix-scheduling-to-access/diff
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1973>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1928: support make parallel options in simfactory
-------------------------+--------------------------------------------------
Reporter: rhaas | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: SimFactory | Version: development version
Keywords: |
-------------------------+--------------------------------------------------
Pull request https://bitbucket.org/simfactory/simfactory2/pull-requests/11
/parallel-make/diff adds a --jobs option to sim build that sets a
@MAKEJOBS@ replacement so that one can use make -j @MAKEJOBS@ in machine
definitons files and let the user choose the number of make jobs when
compiling
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1928>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1975: Cactus: mark routines used by DECLARE_CCTK_ARGUMENTS as pure
-------------------------+--------------------------------------------------
Reporter: rhaas | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: Cactus | Version: development version
Keywords: |
-------------------------+--------------------------------------------------
Currently CCTK_DECLARE_ARGUMENTS contains code like this:
{{{
static int varindex = -100;
if (varindex == -100) varindex = CCTK_VarIndex("thorn::var");
var = CCTKi_VarDataPtr(cctGH, 0, varindex);
}}}
ie it calls the two functions VarIndex and VarDataPtr for all variables
that the thorn defines or inherits. This happens no matter whether the
variable "var" is later used in the routine or not since the two functions
could have side effects. The patch in the pull requests declares the
functions "pure", ie side effect free (https://gcc.gnu.org/onlinedocs/gcc
/Common-Function-Attributes.html#index-functions-that-have-no-side-
effects-3320) which lets the compiler remove the call to the functions if
their result is not used.
Technically CCTK_VarIndex does have a side effect: it can call CCTK_VWarn
(at level 6) for unknown variable names though the result does not affect
the computation. CCTKi_VarDataPtr is explicitly designed to be side-effect
free.
The patch would lead to slightly smaller code and possible slightly faster
code as well when CCTK_DECLARE_ARGUMENTS is used often or with many
inherited variables.
The pull request is at https://bitbucket.org/cactuscode/cactus/pull-
requests/34/cactus-mark-routines-used-by/diff
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1975>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit