Trac

trac@lists.einsteintoolkit.org

8708 discussions

#2747: Inclusion of sgrid importer in Einstein Toolkit
by Michal Pirog 03 Oct '23

03 Oct '23

#2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: new Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Michal Pirog): We've made some changes and pushed them to ExternalLibraries-SGRID. Can you try again? -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgri…

1 0

#2747: Inclusion of sgrid importer in Einstein Toolkit
by Samuel Cupp 02 Oct '23

02 Oct '23

#2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: new Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Samuel Cupp): When I try to compile, I get errors like ``` /usr/bin/ld: /home/sam/grav/toolkit/tmp/Cactus/configs/sim/scratch/external/SGRID/lib/libsgrid.a(Coordinates.o): in function `xyz_of_AnsorgNS': Coordinates.c:(.text+0xa48e): undefined reference to `GOMP_critical_name_start' /usr/bin/ld: Coordinates.c:(.text+0xa4dc): undefined reference to `GOMP_critical_name_end' /usr/bin/ld: Coordinates.c:(.text+0xac01): undefined reference to `GOMP_critical_name_start' /usr/bin/ld: /home/sam/grav/toolkit/tmp/Cactus/configs/sim/scratch/external/SGRID/lib/libsgrid.a(Coordinates.o): in function `dABphi_dxyz_AnsorgNS': Coordinates.c:(.text+0xb8cc): undefined reference to `GOMP_critical_name_start' /usr/bin/ld: Coordinates.c:(.text+0xb91c): undefined reference to `GOMP_critical_name_end' /usr/bin/ld: Coordinates.c:(.text+0xd14c): undefined reference to `GOMP_critical_name_start' /usr/bin/ld: /home/sam/grav/toolkit/tmp/Cactus/configs/sim/scratch/external/SGRID/lib/libsgrid.a(Coordinates.o): in function `xyz_of_AnsorgNS': Coordinates.c:(.text+0xac9b): undefined reference to `GOMP_critical_name_end' /usr/bin/ld: /home/sam/grav/toolkit/tmp/Cactus/configs/sim/scratch/external/SGRID/lib/libsgrid.a(Coordinates.o): in function `dABphi_dxyz_AnsorgNS': Coordinates.c:(.text+0xd27b): undefined reference to `GOMP_critical_name_end' /usr/bin/ld: /home/sam/grav/toolkit/tmp/Cactus/configs/sim/scratch/external/SGRID/lib/libsgrid.a(DNSgrid.o): in function `Interp_Var_From_Grid1_To_Grid2_star._omp_fn.0': DNSgrid.c:(.text+0x205): undefined reference to `omp_get_num_threads' /usr/bin/ld: DNSgrid.c:(.text+0x20c): undefined reference to `omp_get_thread_num' ``` Is ExternalLibraries/SGRID not properly hooking into the OMP in the toolkit? -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgri…

1 0

#2553: Cactus' link command uses CPPFLAGS and CXXFLAGS
by Steven R. Brandt 29 Sep '23

29 Sep '23

#2553: Cactus' link command uses CPPFLAGS and CXXFLAGS Reporter: Roland Haas Status: open Milestone: Version: development version Type: bug Priority: minor Component: Cactus Comment (by Steven R. Brandt): For the upcoming release, we need to compile with nvcc. This leads to errors in ctthorns because Kranc detects cuda and starts putting the device tag on its functions. This leads to compiler failures for ctthorns. If we didn’t have to set CXX globally to nvcc, this problem should go away. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2553/cactus-link-comma…

1 0

#2747: Inclusion of sgrid importer in Einstein Toolkit
by Roland Haas 28 Sep '23

28 Sep '23

#2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: new Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Roland Haas): GetComponents supports some very limited replacement variables in the `URL`, `AUTH_URL` and `REPO_PATH` variables, namely it will take the `<ARRANGEMENT>/<THORN>` entry of each thorn and will assign `<ARRANGEMENT>` to `$1` $ie the first thingy$ and `$2` will be set to `<THORN>` $ie the second component$. More or less like Perl with do when one used a pattern `m!([^/]*)/(.*)!`. There is _also_ some magic in how `REPO_PATH` behaves depending on whether it does or does not contain a `$1` or `$2`. If it does contain a `$1` or `$2` then the relative path inside of the repository will be exactly as given by `REPO_PATH` $after variable expansion$. If on the other hand no `$1` or `$2` is found, then the relative path in the repo is `<REPOS_PATH>/<ARRANGEMENT>/<THORN>`. What needs to go into `REPO_PATH` thus hugely depends on the git repository layout. `$2` often works nicely because people tend to put all thorns into the root of the git repo. `..` is somewhat unusual. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgri…

1 0

#2747: Inclusion of sgrid importer in Einstein Toolkit
by Michal Pirog 27 Sep '23

27 Sep '23

#2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: new Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Michal Pirog): First: I hope it's all we need to add, and I'll be more than happy if you do it. Thanks! Second: It's Wolfgang's repo, so I think we should ask him. I'm writing an email to him right now. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgri…

1 0

#2746: Make Seed_Magnetic_Fields independent of IllinoisGRMHD
by Samuel Cupp 27 Sep '23

27 Sep '23

#2746: Make Seed_Magnetic_Fields independent of IllinoisGRMHD Reporter: Samuel Cupp Status: new Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Samuel Cupp): -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2746/make-seed_magneti…

1 0

#2746: Make Seed_Magnetic_Fields independent of IllinoisGRMHD
by Samuel Cupp 27 Sep '23

27 Sep '23

1 0

#2747: Inclusion of sgrid importer in Einstein Toolkit
by Samuel Cupp 27 Sep '23

27 Sep '23

#2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: new Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Samuel Cupp): This means adding the thorns to the `einsteintoolkit.th` in the master branch of the manifest $[link](https://bitbucket.org/einsteintoolkit/manifest/src/master/einsteintoolkit.th)$. As long as the thorns are in a publicly accessible repo, it should be fine. Note that we usually make branches and tags for every single release on these repositories $see, for example, the plethora of `ET_YYYY_MM` branches in [wvuthorns](https://bitbucket.org/zach_etienne/wvuthorns/src/master/)$. This either means giving the ET maintainers permission to create branches in the repository $and possibly letting any future release managers/maintainers have access$ or be willing to create these branches and tags on behalf of the ET. Generally, letting at least a few of the senior maintainers have commit access will help ensure smooth future releases in case people get sick or something at the same time as a release. So right now, the most important thing is making sure we put in the correct information. Based on what is in the linked git repo, it is ``` !TARGET = $ARR !TYPE = git !URL = https://github.com/wofti/CactusSgrid.git !REPO_PATH = .. !CHECKOUT = CactusSgrid/DNSdata ``` If that’s all we need to add, then I can do that today. @{634afd8853df3c01232121fd} what does the `$2` that most thorns use mean for repo\_path? I ask because I don’t know if the `..` in the above is what GetComponents normally expects or not. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgri…

1 0

#2747: Inclusion of sgrid importer in Einstein Toolkit
by Michal Pirog 27 Sep '23

27 Sep '23

#2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: new Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Michal Pirog): I was convinced that there is some specific place where files must be uploaded. Anyway, I'm still confused. There is a deadline today which says: "2023-09-27 $-10wk$: all codes proposed for inclusion in master branch $still under review$ \[dates pushed back for delayed release\]" What should I/we do to not miss this deadline. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgri…

1 0

#2746: Make Seed_Magnetic_Fields independent of IllinoisGRMHD
by Samuel Cupp 27 Sep '23

27 Sep '23

#2746: Make Seed_Magnetic_Fields independent of IllinoisGRMHD Reporter: Samuel Cupp Status: new Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Samuel Cupp): The associated PR: [https://bitbucket.org/zach\_etienne/wvuthorns/pull-requests/14](https://bit… -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2746/make-seed_magneti…

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Trac