#2747: Inclusion of sgrid importer in Einstein Toolkit
Reporter: Samuel Cupp
Status: new
Milestone: ET_2023_11
Version:
Type: enhancement
Priority: major
Component: EinsteinToolkit thorn
Comment (by Roland Haas):
You don’t have to upload it anywhere, really. All that is needed for it to be “in the Einstien Toolkit” is that there is a correct checkout line of it in the official ET thornlist in the ET “manifest” repository \(since, strictly speaking, this is all the ET is: a collated list of externally developed software\).
_If_ you however would like to have the code hosted somewhere that is not e.g. your pesonal github or Bitbucket account \(eg b/c you may change jobs, or b/c you would need to grant at least some access to the ET release chair / a maintainer\) it can also be moved into an appropriate repository in [https://github.com/einsteintoolkit](https://github.com/einsteintoolkit) e.g. the thorn could go into “EinsteinInitialdata”. Downside: you lose some “branding” since your name no longer appears in the URL, upside you do not have to eg handle access and the ET maintainers will take care of the all steps required for each release.
Examples for “include” are eg the Outflow thorn in EinsteinAnalysis. Examples for “not include” are eg Carpet.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgri…
#2747: Inclusion of sgrid importer in Einstein Toolkit
Reporter: Samuel Cupp
Status: new
Milestone: ET_2023_11
Version:
Type: enhancement
Priority: major
Component: EinsteinToolkit thorn
Comment (by Michal Pirog):
Publicly available repo is here:
[https://github.com/wofti/CactusSgrid.git](https://github.com/wofti/CactusSg…
The thorn itself is at the directory "DNSData" \("BNSData" is an old version\)
We are using the thornlist "[dns.th](http://dns.th)" from the directory "useful\_files" as an argument for "GetComponents".
Finally, we compile Cactus with the option list "dns.cfg" from the directory "useful\_files".
PS: "README" is to update. And I need to prepare some .par file for testing. Again: where exactly should I upload this thorn?
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgri…
#2745: Inclusion of GRHayL library and associated MHD thorns
Reporter: Samuel Cupp
Status: new
Milestone: ET_2023_11
Version:
Type: enhancement
Priority: major
Component: EinsteinToolkit thorn
Comment (by Samuel Cupp):
The Balsara0 test is passing now in the CI. Let me know if there’s any issues.
Since CarpetX is in now, I enabled `GRHayLIDX` and `GRHayLHDX` so the tests can run.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2745/inclusion-of-grha…
#2758: icpc 19 fails to compile AMReX
Reporter: Roland Haas
Status: new
Milestone:
Version:
Type: bug
Priority: major
Component: EinsteinToolkit thorn
AMReX contains code like this:
```c++
#include <string_view>
static constexpr std::string_view parser_f2_s[] =
{
"pow",
"atan2",
"gt",
"lt",
"geq",
"leq",
"eq",
"neq",
"and",
"or",
"heaviside",
"jn",
"min",
"max",
"fmod"
};
```
which fails to compile with “icpc \(ICC\) 19.1.3.304 20200925” with
```
$ icpc -gxx-name=g++ -std=gnu++17 -c dummy.cc
dummy.cc(4): error: expression must have a constant value
{
^
dummy.cc(3): note: attempt to access run-time storage
static constexpr std::string_view parser_f2_s[] =
^
compilation aborted for dummy.cc (code 2)
```
a workaround is to manually count the vector elements:
```
static constexpr std::string_view parser_f2_s[15] =
```
which compiles fine. g\+\+ is gcc-9.3.0, which itself would compile the file fine \(so it is a compiler issue, not a STL issue\). Can be tested on db1.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2758/icpc-19-fails-to-…
#2745: Inclusion of GRHayL library and associated MHD thorns
Reporter: Samuel Cupp
Status: new
Milestone: ET_2023_11
Version:
Type: enhancement
Priority: major
Component: EinsteinToolkit thorn
Comment (by Peter Diener):
I have compiled with both the gnu and intel compilers on my laptop and find that the test “Balsara1” fails with the intel compilers but passes with the gnu compilers. Looking at this in more details, it looks to be an issue with the initial data setup. In the parameter file, the discontinuity position is set to zero. With the gnu compilers this results in the pressure being 1 at x=0 and 0.1 at x=0.000625. With the intel compilers the pressure is 1 at x=-0.000625 and 0.1 at x=0. So somehow the iniitlal profile is shifted by dx. Looks like there is some sensitivity to difference in rounding between the compilers.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2745/inclusion-of-grha…
#2747: Inclusion of sgrid importer in Einstein Toolkit
Reporter: Samuel Cupp
Status: new
Milestone: ET_2023_11
Version:
Type: enhancement
Priority: major
Component: EinsteinToolkit thorn
Comment (by Samuel Cupp):
Is the thorn not publicly available? There’s no way to include a thorn that isn’t public as far as I’m aware. A public repo needs to be set up asap in order for it to be able to be checked out by the toolkit. I didn’t realize this was all still private.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgri…
#2747: Inclusion of sgrid importer in Einstein Toolkit
Reporter: Samuel Cupp
Status: new
Milestone: ET_2023_11
Version:
Type: enhancement
Priority: major
Component: EinsteinToolkit thorn
Comment (by Michal Pirog):
I would like to upload the thorn's files for Liwei
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgri…
#2747: Inclusion of sgrid importer in Einstein Toolkit
Reporter: Samuel Cupp
Status: new
Milestone: ET_2023_11
Version:
Type: enhancement
Priority: major
Component: EinsteinToolkit thorn
Comment (by Samuel Cupp):
In the upper right of the ticket page, there should be a `more` option that drops down to give the attach file option. What exactly are you trying to upload?
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgri…
#2747: Inclusion of sgrid importer in Einstein Toolkit
Reporter: Samuel Cupp
Status: new
Milestone: ET_2023_11
Version:
Type: enhancement
Priority: major
Component: EinsteinToolkit thorn
Comment (by Michal Pirog):
Hi there. I have a silly question. Can you explain to me where and how I can upload my files here to make it available to whoever is involved?
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgri…