#1689: Cactus should exit with a nonzero exit code if an error occurs
--------------------+-------------------------------------------------------
Reporter: hinder | Owner:
Type: defect | Status: new
Priority: minor | Milestone:
Component: Cactus | Version: development version
Keywords: |
--------------------+-------------------------------------------------------
In WarnLevel.c, in CCTK_VWarn (called by CCTK_Warn), it says
if (level <= error_level)
{
CCTK_Abort (NULL, 0);
}
The second argument to CCTK_Abort is the exit code of the process. So if
there is an "error" warning, the process exits with 0 exit code; i.e.
success! This happens in several places in this file.
The user guide does not say anything about the exit code of Cactus. I
think that if Cactus has a level-0 warning, i.e. an error, then it should
exit with a non-zero exit code, and Erik agrees.
See
http://lists.einsteintoolkit.org/pipermail/users/2014-November/003878.html
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1689>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1876: revision 132 of HDF5 fails to build
-----------------------------------+----------------------------------------
Reporter: rhaas | Owner:
Type: defect | Status: new
Priority: blocker | Milestone:
Component: EinsteinToolkit thorn | Version: development version
Keywords: HDF5 |
-----------------------------------+----------------------------------------
revision 132 of HDF5 fails to build in the Jenkins test servers:
https://build.barrywardell.net/job/EinsteinToolkit/735/changes
A first glance at the output show that in configure.ccl it refers to
detect.pl which does not exist (instead of detect.sh).
This is a blocker since an ET thorn fails to compile.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1876>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1864: Cactus build fails on file systems that do not update timestamps all the
time
--------------------+-------------------------------------------------------
Reporter: rhaas | Owner:
Type: defect | Status: new
Priority: major | Milestone:
Component: Cactus | Version: development version
Keywords: |
--------------------+-------------------------------------------------------
Ian and I recently ran into an issue caused by a particular file system
(NFS v4 and also BeeGFS) not updating the file modification time when
doing this:
{{{
: >make.checked
}}}
which is what the build system uses (since
[https://bitbucket.org/cactuscode/cactus/commits/0779c17697d3b4a254065c10836…
0779c17697d3b4a254065c10836770e355071f41] "Cactus: Replace "echo" by ":"
in makefile" Thu Nov 27 16:35:13 2014 -0500) to update the marker files
once a directory is finished building. While such a behaviour is not POSIX
compliant (https://bugzilla.kernel.org/show_bug.cgi?id=6127), we'd still
want to work around it.
The simplest solution seems to me to revert
[https://bitbucket.org/cactuscode/cactus/commits/0779c17697d3b4a254065c10836…
0779c17697d3b4a254065c10836770e355071f41] and use
{{{
echo "" >make.checked
}}}
again. Erik: since you made the change, would you see any downside to
reverting it?
While investigating this Ian also found that some file systems only offer
1 second granularity in their timestamps (eg ext3 but also possibly XFS
and NFS) which can negatively affect make if a rule takes less than a
second to complete. See https://savannah.gnu.org/bugs/?40056#comment0 and
https://www.gnu.org/software/autoconf/manual/autoconf-2.61/html_node
/Timestamps-and-Make.html . The most conservative approach would be to
(arrange for) {{{sleep 1}}} to execute after each make recipe.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1864>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1837: LocalInterp2 symmetry test fails on intel compiler machine
-----------------------------------+----------------------------------------
Reporter: rhaas | Owner:
Type: defect | Status: new
Priority: minor | Milestone:
Component: EinsteinToolkit thorn | Version: development version
Keywords: LocalInterp2 |
-----------------------------------+----------------------------------------
The intel compiler by default aggressively optimizes expressions, which
causes failures in the delicate cancellations required for LocalInterp2's
symmetry test.
The attached patch changes compiler options for the affected file only.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1837>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#702: Tests should use IO::out_fileinfo = "none"
-------------------------+--------------------------------------------------
Reporter: hinder | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: Other | Version:
Keywords: |
-------------------------+--------------------------------------------------
The Cactus User Guide
(http://einsteintoolkit.org/documentation/UsersGuide/UsersGuidech9.html#x13-…)
recommends that test output files should always be the same, and hence use
IO::out_fileinfo = "none". I would like to implement this for the tests
in the ET, as it makes comparing test output using standard (non-Cactus
testsuite mechanism) diff tools possible.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/702>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1866: do not compress pdf files stored in Cactus repo
---------------------------+------------------------------------------------
Reporter: rhaas | Owner:
Type: enhancement | Status: new
Priority: optional | Milestone:
Component: Cactus | Version: development version
Keywords: documentatino |
---------------------------+------------------------------------------------
Compressing the pdf files means that changes propagate through the file
and a change at the beginning of the file cause changes in all of the
compressed file, effectively disabling git's delta compression of blobs.
The patch proposed in https://bitbucket.org/cactuscode/cactus/pull-
requests/23/cactus-disable-compression-in-included-pdf/diff disables pdf
compression
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1866>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1631: The dgfe branch for McLachlan generates NaNs
-----------------------------------------------------------+----------------
Reporter: Jonah Miller <jonah.maxwell.miller@…> | Owner: eschnett
Type: defect | Status: new
Priority: optional | Milestone: ET_2014_11
Component: EinsteinToolkit thorn | Version: development version
Keywords: dgfe,mclachlan,gamma driver |
-----------------------------------------------------------+----------------
When one uses the gamma driver formulation in the dgfe branch of McLachlan
and sets the shiftGammaCoefficient to zero, the runtime output has NaNs
because the code divides by zero.
A bit of flow control fixes this. Attached is a patch for the branch.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1631>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1871: Error compiling
------------------------------------+---------------------------------------
Reporter: cabarbosad@… | Owner:
Type: defect | Status: new
Priority: critical | Milestone: ET_2015_11
Component: EinsteinToolkit thorn | Version: development version
Keywords: |
------------------------------------+---------------------------------------
Hi,
I'm compiling and have next error:
/home/campc/Cactus/configs/config1/lib/libthorn_ADMConstraints.a(ADMConstraints.F.o):
En la función `admconstraints_boundaries_':
ADMConstraints.f:(.text+0x67bd): referencia a `cctk_equals_' sin definir
ADMConstraints.f:(.text+0x67f7): referencia a `boundary_selectgroupforbc_'
sin definir
ADMConstraints.f:(.text+0x6829): referencia a `boundary_selectgroupforbc_'
sin definir
ADMConstraints.f:(.text+0x6887): referencia a `boundary_selectgroupforbc_'
sin definir
ADMConstraints.f:(.text+0x68b9): referencia a `boundary_selectgroupforbc_'
sin definir
ADMConstraints.f:(.text+0x6861): referencia a `boundary_selectgroupforbc_'
sin definir
collect2: error: ld returned 1 exit status
make[1]: *** [/home/campc/Cactus/exe/cactus_config1] Error 1
make: *** [config1] Error 2
I appreciate your help
tks,
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1871>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1646: McLachlan does not give a reference for the gauge evolution equations
-----------------------------------+----------------------------------------
Reporter: rhaas | Owner:
Type: defect | Status: new
Priority: minor | Milestone:
Component: EinsteinToolkit thorn | Version: development version
Keywords: McLachlan |
-----------------------------------+----------------------------------------
McLachlan_BSSN.m does not seem to contain any information (eg in evolCalc)
that would tell me from which paper the different expressions for the
shift and lapse evolution expression are taken from (which may be useful
to understand what the different coefficients mean, since parsing the
multiple factors of the type XXXFactor * AAA + (1-XXXFactor) * BBB to get
either AAA or BBB is confusing).
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1646>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit