#1016: External library dependencies not taken into account
----------------------+-----------------------------------------------------
Reporter: eschnett | Owner:
Type: defect | Status: new
Priority: major | Milestone:
Component: Cactus | Version:
Keywords: |
----------------------+-----------------------------------------------------
I find that dependencies between external libraries are not taken into
account when creating the library link order. That is, "REQUIRES" and
"OPTIONAL" specifications are ignored.
I believe I have isolated the problem and will propose a patch soon.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1016>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1032: change HDF5's file open options to close all sub-file objects when a file
is closed
--------------------------+-------------------------------------------------
Reporter: rhaas | Owner: eschnett
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: Carpet | Version:
Keywords: CarpetIOHDF5 |
--------------------------+-------------------------------------------------
this is strictly speaking not necessary, since any need for it is caused
by a HDF5 object leak. On the other hand it does not hurt either
additionally one could overload H5Fclose and warn the user when there are
still open objects when a file is closed, ie:
{{{
//////////////////////////////////////////////////////////////////////////////
// Close HDF5 file checking for leaked objects
//////////////////////////////////////////////////////////////////////////////
static herr_t H5Fclose (hid_t file)
{
DECLARE_CCTK_PARAMETERS;
herr_t retval;
int error_count = 0;
hsize_t objectcount;
HDF5_ERROR (objectcount = H5Fget_obj_count(file,
H5F_OBJ_ALL |
H5F_OBJ_LOCAL));
if (objectcount > 1) {
std::vector<char> fn;
hsize_t sz_fn;
HDF5_ERROR (sz_fn = H5Fget_name(file, NULL, 0));
fn.resize(sz_fn+1);
HDF5_ERROR (H5Fget_name(file, &fn[0], fn.size()));
CCTK_VWarn (1, __LINE__, __FILE__, CCTK_THORNSTRING,
"%d open HDF5 objects when closing file '%s'",
int(objectcount)-1, &fn[0]);
}
HDF5_ERROR (retval = ::H5Fclose (file));
return retval;
}
}}}
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1032>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1030: defer (re)opening checkpoint files until we need to
--------------------------+-------------------------------------------------
Reporter: rhaas | Owner: eschnett
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: Carpet | Version:
Keywords: CarpetIOHDF5 |
--------------------------+-------------------------------------------------
this patch defers opening checkpoint files until we need to do so because
either we need to browse them or open a dataset for reading. This speeds
up open_one_file_at_a_time since it will not open a hdf5 file that was
already parsed and does not contain useful datasets.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1030>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1029: support indices in sequential chunked output files
--------------------------+-------------------------------------------------
Reporter: rhaas | Owner: eschnett
Type: defect | Status: new
Priority: minor | Milestone:
Component: Carpet | Version:
Keywords: CarpetIOHDF5 |
--------------------------+-------------------------------------------------
this patch makes sure that even the sequential file writer writes correct
index files. Right now this writer is (always) used when Carpet runs on a
single process. Generated index files are currently invalid since the
MetaData group is written but nothing else.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1029>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1028: do not re-parse file when using open_one_input_file_at_a_time
-------------------------+--------------------------------------------------
Reporter: rhaas | Owner: eschnett
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: Carpet | Version:
Keywords: |
-------------------------+--------------------------------------------------
this patch retains the patch map created when reading a file even when the
file itself is closed due to open_one_input_file_at_a_time. Since parsing
the file is slow this can considerably speed up
open_one_input_file_at_a_time.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1028>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1027: close small memory leak in CarpetIOHDF5
--------------------------+-------------------------------------------------
Reporter: rhaas | Owner: eschnett
Type: defect | Status: new
Priority: minor | Milestone:
Component: Carpet | Version:
Keywords: CarpetIOHDF5 |
--------------------------+-------------------------------------------------
this patches closes a memory leak in CarpetIOHDF5 when using
open_one_input_file_at_a_time, where the HDF5 file would be closed, but
the data read out out it was not freed which would cause storage for it to
be reallocated again when the file is opened again for the next refinement
level. It also properly closes a HDF5 property that was left dangling
otherwise.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1027>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#380: AHFinderDirect failure with qc0-mclachlan.par
--------------------+-------------------------------------------------------
Reporter: hinder | Owner:
Type: defect | Status: new
Priority: major | Milestone: ET_2011_05
Component: Other | Version:
Keywords: |
--------------------+-------------------------------------------------------
Trying to run the par/qc0-mclachlan.par in the ET trunk gives the
following error:
INFO (AHFinderDirect): proc 0: searching for horizons 1,5/6
WARNING level 0 in thorn CarpetInterp processor 0 host kop193.datura.admin
(line 1683 of
/home/ianhin/Cactus/etrelease/arrangements/Carpet/CarpetInterp/src/interp.cc):
-> Grid function "AHFINDERDIRECT::ahmask" has only 1 active time levels
on refinement level 1; this is not en
ough for time interpolation
See also #373, which might be related.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/380>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#488: Reduce space taken by Formaline tarballs
-------------------------+--------------------------------------------------
Reporter: hinder | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: Cactus | Version:
Keywords: Formaline |
-------------------------+--------------------------------------------------
When syncing lightweight data of simulations from a cluster, much of the
time and disk space on the local system is taken with Formaline tarballs.
It would be good to reduce this.
I propose opportunistically replacing the generated tarballs with hard-
links to existing tarballs on the same filesystem after Formaline has
written them to the new output directory if the files compare equal.
These could be from previous restarts of the same simulation when using
simfactory. Then, if an entire simulation is rsynced with the appropriate
options, hard-links will be transferred as hard-links, and the overall
transfer time and disk space used will be significantly reduced.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/488>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit