#814: Allow different timers on different processors in TimerReport
-----------------------------------+----------------------------------------
Reporter: eschnett | Owner:
Type: defect | Status: new
Priority: major | Milestone:
Component: EinsteinToolkit thorn | Version:
Keywords: |
-----------------------------------+----------------------------------------
This patch reduces not just timer values, but also timer names across
processes. This allows different processes to have different timers.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/814>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#901: bashism in ThornDoc
--------------------+-------------------------------------------------------
Reporter: knarf | Owner:
Type: defect | Status: new
Priority: minor | Milestone: ET_2012_05
Component: Cactus | Version: development version
Keywords: |
--------------------+-------------------------------------------------------
ThornDoc uses '==' within 'test' to test for something being equal.
However, for shell scripts this should be '='. This works in bash, since
it also accepts '==', but it does not work for /bin/sh by default, which
is what ThornDoc claims to be a script for. The effect is that 'make
THORN-ThornDoc' prints a lot of warnings.
The attached patch fixes this by replacing '==' with '='.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/901>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#824: Update tests which rely on BSSN_MoL to use ML_BSSN instead
------------------------+---------------------------------------------------
Reporter: hinder | Owner:
Type: task | Status: new
Priority: major | Milestone: ET_2012_05
Component: Other | Version:
Keywords: testsuites |
------------------------+---------------------------------------------------
BSSN_MoL is not part of the toolkit. Many thorns which are part of the
toolkit have tests which rely on BSSN_MoL. These tests currently do not
run. In order to test these thorns, the tests should be updated to use
ML_BSSN instead of BSSN_MoL.
Correctness-testing the new results (which will be different due to
differences in the implementation of BSSN) is problematic. I propose that
if the tests run with ML_BSSN and do not generate NaNs or poison, we
should just commit the new test data. These are only regression tests
anyway - there is no formal correctness-testing framework.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/824>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#897: Hydro_InitExcision tests failing
-----------------------------------+----------------------------------------
Reporter: rhaas | Owner:
Type: defect | Status: new
Priority: major | Milestone:
Component: EinsteinToolkit thorn | Version:
Keywords: Hydro_InitExcision |
-----------------------------------+----------------------------------------
with the atmosphere fixes from r332 of GRHydro the following
Hydro_InitExcision tests started to fail:
* diag_pugh_tvd (from Hydro_InitExcision)
* halfsphere_pugh_ppm (from Hydro_InitExcision)
* halfsphere_pugh_tvd (from Hydro_InitExcision)
* sphere_pugh_tvd (from Hydro_InitExcision)
* x_pugh_tvd (from Hydro_InitExcision)
the attached patch regenerates the data. I have checked that reverting the
GRHydro patch makes the tests pass. Ok to apply?
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/897>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#848: McLachlan "NewRad" radiative boundary condition does not consider
conformalMethod
-----------------------+----------------------------------------------------
Reporter: hinder | Owner:
Type: defect | Status: new
Priority: minor | Milestone:
Component: Other | Version:
Keywords: McLachlan |
-----------------------+----------------------------------------------------
In ML_BSSN_Helper/src/NewRad.c, the newrad function is called with a
background value of 0 for the phi variable, independently of the setting
of conformalMethod. For conformalMethod = 1, the background value should
be 1.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/848>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#862: Make HDF5 output in AHFinderDirect work
-----------------------------------+----------------------------------------
Reporter: eschnett | Owner:
Type: defect | Status: new
Priority: minor | Milestone:
Component: EinsteinToolkit thorn | Version:
Keywords: |
-----------------------------------+----------------------------------------
Ian Hinder sees errors when trying to use HDF5 output of AHFinderDirect. I
see lines "#ifdef CCTK_HDF5" that should probably be "#ifdef
HAVE_CAPABILITY_HDF5" instead. Also, an "OPTIONAL: HDF5" may be missing in
the configuration.ccl.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/862>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#889: GRHydro atmosphere bug
----------------------+-----------------------------------------------------
Reporter: reisswig | Type: defect
Status: new | Priority: critical
Milestone: | Component: EinsteinToolkit thorn
Version: | Keywords: GRHydro, atmosphere
----------------------+-----------------------------------------------------
I have fixed a bug in GRHydro's atmosphere handling after reconstruction.
After reconstruction, the reconstructed plus and minus face values are
tested for whether they drop below atmosphere level and are then reset.
In particular, this means that plus and minus face values for cell i don't
generally coincide with the minus/plus face values of the corresponding
cells i-1 and i+1.
If the reconstruction previously found that the Riemann problem was
trivial between, say rhominus(i+1) and rhoplus(i), when changing
rhoplus(i), it is not anymore!
However, the mask "trivial_rp" testing for a trivial Riemann problem is
not changed!
This leads to inconsistent behavior at the boundary of the atmosphere.
The symptom was a drift in the center of mass of a static and perfectly
symmetric TOV star.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/889>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#827: merge bugfixes from Zelmani into main branch
-----------------------------------+----------------------------------------
Reporter: rhaas | Owner:
Type: defect | Status: new
Priority: major | Milestone:
Component: EinsteinToolkit thorn | Version:
Keywords: |
-----------------------------------+----------------------------------------
A while ago we moved GRMHD development (for various reasons) from the main
repository into a git repository (Zelmani). Since then we have accumulated
a number of (important) bugfixes (in particular for MHD but also for other
subsystems) in that repository.
Should we mere them back (this soon before the release)?
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/827>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#794: Thorn ADMMass should be included in the Einstein Toolkit
-----------------------------------+----------------------------------------
Reporter: hinder | Owner:
Type: enhancement | Status: new
Priority: major | Milestone: ET_2012_05
Component: EinsteinToolkit thorn | Version:
Keywords: |
-----------------------------------+----------------------------------------
There was a discussion
(http://lists.einsteintoolkit.org/pipermail/users/2011-December/thread.html#…)
on the ET mailing list about adding the thorn ADMMass to the toolkit. The
decision was made to do so once some documentation was added. This should
be done before the next release.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/794>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit