Users June 2010

users@lists.einsteintoolkit.org

19 participants
61 discussions

Kranc/McLachlan incompatibility
by Erik Schnetter 22 Jun '10

22 Jun '10

The current version of Kranc cannot digest the current version of McLachlan. The problem is with enforcing the trace A constraint, where the variable At_ij is both read and written -- Kranc does not emit the statement that reads the local variable from the grid function. The enclosed patch corrects this. It is somewhat lengthy and not entirely elegant: Output assignments for all temporaries, not only for those that are only used in the RHS. If a temporary is used in a LHS, it may still need to be loaded from a grid function. Add a somewhat complex logic to ensure that each temporary and shortcut is declared only once. When declaring temporaries, do not declare them as constant, because they may change. -erik -- Erik Schnetter <schnetter(a)cct.lsu.edu> http://www.cct.lsu.edu/~eschnett/

3 6

Feature request: Check repository urls in GetComponents
by Erik Schnetter 22 Jun '10

22 Jun '10

I just found that I had an old Kranc checkout from the wrong repository. Get Components did not notice this, and updated from this repository instead of aborting and/or switching to the new repository. (This explains why my version of Kranc didn't work.) GetComponents should check this, and warn/abort if the checked out repository url is different from the one specified in the thorn list. I assume that people will move repositories from time to time for various reasons, and sticking with the wrong/old one should be noticed. -erik -- Erik Schnetter <schnetter(a)cct.lsu.edu> http://www.cct.lsu.edu/~eschnett/

2 1

Patch: Support wide boundaries in ML_ADMConstraints
by Erik Schnetter 21 Jun '10

21 Jun '10

Support arbitrarily wide boundaries in ML_ADMConstraints and ML_ADMQuantities. The constraints and ADM quantities cannot be calculated on the boundary. This boundary may be wider than one grid point. Also, the code needs to be regenerated. -erik -- Erik Schnetter <schnetter(a)cct.lsu.edu> http://www.cct.lsu.edu/~eschnett/

1 0

Patch: Update IDConstraintViolate example to ML
by Erik Schnetter 21 Jun '10

21 Jun '10

Update the example parameter file in thorn IDConstraintViolate to using McLachlan. (Note: the test case should also be updated.) -erik -- Erik Schnetter <schnetter(a)cct.lsu.edu> http://www.cct.lsu.edu/~eschnett/

1 0

Meeting reminder
by Frank Loeffler 21 Jun '10

21 Jun '10

Hi, this is a short reminder about the regular EinsteinToolkit phone call later today (at 10am CDT). Apart from congratulating ourselves to have a release, we already have to discuss two patches (GetComponents and GRHydro). We will also discuss and form more specific plans for the MHD implementation. Frank

4 6

Suggestion for release-patch
by Frank Loeffler 21 Jun '10

21 Jun '10

On Sun, Jun 20, 2010 at 09:53:40PM +0000, knarf(a)cct.lsu.edu wrote: > Fix error in ppm when using GRHydro_enable_internal_excision == no (which is _not_ the default setting). Thanks go to Christian Ott. Hi, I suggest to apply this patch also to the just-released version of GRHydro. Here are some details first (if you care to know): The old code (now also released) produces bogus data if ppm is used and the internal GRHydro-excision is turned off by the parameter GRHydro::GRHydro_enable_internal_excision. However, the default is to have it on and let the excision mask decide. This works. The only reason not to use the internal excision method is to use your own. To the best of my knowledge the only other method is used by Christian Ott, who got bitten by this bug and who also found the specific location of the problem. On the other hand, someone might just think it would be a good idea to turn this off just because there is no excision happening in their runs. Now, in short, arguments for applying this to the released version: - It fixes a severe bug. - The patch is not big. Reviewing it should not take long. A reason _not_ to apply it is - The bug is not triggered with default settings and there is no strong reason to change that unless you know what you are doing anyway. As I see it, the reasons to apply this patch out-weight the reason not to do so. This is one of (at least) two patches I would like to have discussed at tomorrows call. (the other being the GetComponent-git-update-patch) Frank

2 1

Patch: Use only one thread if OMP_NUM_THREADS is not set
by Erik Schnetter 20 Jun '10

20 Jun '10

Carpet: Use only one thread if OMP_NUM_THREADS is not set Introduce a new value for the parameter Carpet::num_threads: when set to -2, and when the environment variable OMP_NUM_THREADS is not set, then only 1 thread is used instead of a system default. -erik -- Erik Schnetter <schnetter(a)cct.lsu.edu> http://www.cct.lsu.edu/~eschnett/

2 1

Possible Patch for GetComponents
by Eric Seidel 20 Jun '10

20 Jun '10

Hi all, There was a small bug in GetComponents when the EinsteinToolkit was released yesterday, which I would like to address with a patch. The bug occurs when you try to update a git repository; after pulling the latest changes, GetComponents tries to do a "git checkout $branch" again which errors because the branch has already been created when the repo was cloned. Note that this is really just a cosmetic error; it doesn't break anything and the repo stays on the appropriate branch. Let me know what you think, Eric Index: GetComponents =================================================================== --- GetComponents (revision 653) +++ GetComponents (working copy) @@ -909,7 +909,7 @@ my $git_repo = $component{"GIT_REPO"}; my $cmd = ''; my $git_repos_dir = ''; - my $branch = defined($component{REPO_BRANCH}) ? $component{REPO_BRANCH} : 'master'; + my $branch = defined($component{REPO_BRANCH}) ? $component{REPO_BRANCH} : undef; # find a revision from $DATE my $date = defined $DATE ? '$'."($git rev-list --max-count=1 --before=$DATE $branch)" : $branch; @@ -921,10 +921,12 @@ $cmd = "$git clone$shallow $url $ROOT/repos/$git_repo"; print_checkout_info($checkout, $url, $target, $name); run_command($cmd) == 0 or push (@components_error, $checkout); - chdir("$orig_dir/$ROOT/repos/$git_repo"); - run_command("git checkout $branch") == 0 or push (@components_error, $checkout); - run_command("git checkout $date") == 0 or push (@components_error, $checkout); - chdir("$orig_dir"); + if (defined $branch) { + chdir("$orig_dir/$ROOT/repos/$git_repo"); + run_command("git checkout --track -b $branch origin/$branch") == 0 or push (@components_error, $checkout); + #run_command("git checkout $date") == 0 or push (@components_error, $checkout); + chdir("$orig_dir"); + } $updated_git_repos{$git_repo} = 1; } # if git repo has already been cloned, we will pull the latest version @@ -932,8 +934,7 @@ chdir("$orig_dir/$ROOT/repos/$git_repo"); print_checkout_info($checkout, $url, $target, $name); run_command("$git pull -a") == 0 or push (@components_error, $checkout); - run_command("git checkout $branch") == 0 or push (@components_error, $checkout); - run_command("git checkout $date") == 0 or push (@components_error, $checkout); + #run_command("git checkout $date") == 0 or push (@components_error, $checkout); $updated_git_repos{$git_repo} = 1; chdir($orig_dir) @@ -996,9 +997,6 @@ chdir("$orig_dir/$ROOT/repos/$git_repo"); print_update_info($checkout, $url, $target, $name); run_command("$git pull -a") == 0 or push (@components_error, $checkout); - if (defined($branch)) { - run_command("git checkout $branch") == 0 or push (@components_error, $checkout); - } $updated_git_repos{$git_repo} = 1; chdir($orig_dir) } @@ -1706,6 +1704,7 @@ --status run status commands for each component --diff run diff commands for each component --root override root directory + --date checkout from a specific date --reset- authentication delete authentication files @@ -1750,6 +1749,11 @@ Override the root directory in the component list. This allows checking out into an arbitrary directory. +=item B<--date> + +Checkout components from a specific date. Currently only supported for cvs, svn, and mercurial. + + =item B<--reset-authentication> Delete any CRL authentication files before processing the component list.

3 4

Some repository changes
by Erik Schnetter 18 Jun '10

18 Jun '10

During the release process, we introduced release branches to some svn repositories that did not support branches before. In particular, the "manifest" and "par" directories in existing checkouts (of the development version) will now be confused, since they point to the wrong directory on the svn server. It is probably best to save your local changes (if you have any) in these directories, and check them out afresh, using the repository paths in the manifest. You find the current version of the (development version of the) manifest in svn checkout https://svn.einsteintoolkit.org/manifest/trunk manifest If you are using the release, you do not need to worry -- everything is fine there. This concerns only existing checkouts of the development version. -erik -- Erik Schnetter <schnetter(a)cct.lsu.edu> http://www.cct.lsu.edu/~eschnett/

2 2

GetComponents "fatal" errors
by Erik Schnetter 18 Jun '10

18 Jun '10

I receive "fatal" errors when I update certain git repositories that I had checked out before. The log file contains: Jun 18, 10:53:4: Could not run command: git checkout --track -b master origin/master fatal: git checkout: branch master already exists -erik -- Erik Schnetter <schnetter(a)cct.lsu.edu> http://www.cct.lsu.edu/~eschnett/

2 2

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Users June 2010