Dear Einstein Toolkit users,
some time ago I wrote a patch to allow external thorns to perform direct calls to the low-level Periodic API, as I needed to apply periodic conditions only on selected grid variables.
I proposed this patch to Erik, who suggested to implement some improvements and to discuss it on the mailing list. After having implemented his suggestions, somehow I forgot to post the patch also here...
The way in which it works is by simply moving the "logic" (handling of errors and parameters) into Periodic_ApplyBC to make BndPeriodicVI "thorn agnostic".
Best, David
David
This is a good idea. How did you test this change? Did you try a particular test case, or a certain parameter file that uses periodic boundary conditions?
-erik
On Fri, Dec 17, 2010 at 5:16 AM, David Radice david.radice@aei.mpg.de wrote:
Dear Einstein Toolkit users,
some time ago I wrote a patch to allow external thorns to perform direct calls to the low-level Periodic API, as I needed to apply periodic conditions only on selected grid variables.
I proposed this patch to Erik, who suggested to implement some improvements and to discuss it on the mailing list. After having implemented his suggestions, somehow I forgot to post the patch also here...
The way in which it works is by simply moving the "logic" (handling of errors and parameters) into Periodic_ApplyBC to make BndPeriodicVI "thorn agnostic".
Best, David
-- David Radice Max Planck Institute for Gravitational Physics Albert Einstein Institute Am Muehlenberg 1 D-14476 Potsdam Germany
Tel : +49 331 567 7242 Fax : +49 331 567 7499 Room : 1.64 E-Mail : david.radice@aei.mpg.de
Users mailing list Users@einsteintoolkit.org http://lists.einsteintoolkit.org/mailman/listinfo/users
Erik,
On Fri, 2010-12-17 at 14:58 -0600, Erik Schnetter wrote:
This is a good idea. How did you test this change? Did you try a particular test case, or a certain parameter file that uses periodic boundary conditions?
actually I tested it with my private thorn for hydro boundary conditions (with and without direct calls to the low-level interface and with the new and the old versions)... I guess that a similar test could be performed using the wavetoy, but I didn't try it...
In any case the patch doesn't touch the core of the thorn: it just moves a couple of things around... so I don't expect it to cause problems.
Cheers, David
On Sat, Dec 18, 2010 at 3:08 AM, David Radice david.radice@aei.mpg.de wrote:
Erik,
On Fri, 2010-12-17 at 14:58 -0600, Erik Schnetter wrote:
This is a good idea. How did you test this change? Did you try a particular test case, or a certain parameter file that uses periodic boundary conditions?
actually I tested it with my private thorn for hydro boundary conditions (with and without direct calls to the low-level interface and with the new and the old versions)... I guess that a similar test could be performed using the wavetoy, but I didn't try it...
In any case the patch doesn't touch the core of the thorn: it just moves a couple of things around... so I don't expect it to cause problems.
Famous last words...
I think the only test case with periodic boundaries that we have is in thorn ML_BSSN_Test, and I don't know whether it currently works because there were some interactions with the way boundary conditions are handled in Kranc.
Let's apply your patch.
-erik
I have applied this patch.
-erik
On Sat, Dec 18, 2010 at 10:07 PM, Erik Schnetter schnetter@cct.lsu.edu wrote:
On Sat, Dec 18, 2010 at 3:08 AM, David Radice david.radice@aei.mpg.de wrote:
Erik,
On Fri, 2010-12-17 at 14:58 -0600, Erik Schnetter wrote:
This is a good idea. How did you test this change? Did you try a particular test case, or a certain parameter file that uses periodic boundary conditions?
actually I tested it with my private thorn for hydro boundary conditions (with and without direct calls to the low-level interface and with the new and the old versions)... I guess that a similar test could be performed using the wavetoy, but I didn't try it...
In any case the patch doesn't touch the core of the thorn: it just moves a couple of things around... so I don't expect it to cause problems.
Famous last words...
I think the only test case with periodic boundaries that we have is in thorn ML_BSSN_Test, and I don't know whether it currently works because there were some interactions with the way boundary conditions are handled in Kranc.
Let's apply your patch.
-erik
-- Erik Schnetter schnetter@cct.lsu.edu http://www.cct.lsu.edu/~eschnett/
users@lists.einsteintoolkit.org
-
David Radice -
Erik Schnetter